From 31f319b934064be98f32c761dfd16f79b2318675 Mon Sep 17 00:00:00 2001
From: Fangjun Kuang <csukuangfj@gmail.com>
Date: Thu, 21 Dec 2023 20:09:58 +0800
Subject: [PATCH] Release v1.25.4

---
 .github/workflows/run-tests-windows-cpu.yml | 2 +-
 CMakeLists.txt                              | 2 +-
 cmake/cmake_extension.py                    | 1 +
 scripts/conda-cpu/kaldifeat/meta.yaml       | 2 +-
 scripts/conda/kaldifeat/meta.yaml           | 2 +-
 5 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/.github/workflows/run-tests-windows-cpu.yml b/.github/workflows/run-tests-windows-cpu.yml
index 6529b6f..12cbf53 100644
--- a/.github/workflows/run-tests-windows-cpu.yml
+++ b/.github/workflows/run-tests-windows-cpu.yml
@@ -90,7 +90,7 @@ jobs:
       - name: Build kaldifeat
         run: |
           cd build_release
-          cmake --build . --target _kaldifeat --config Release
+          cmake --build -DCMAKE_CXX_STANDARD=17 . --target _kaldifeat --config Release
 
       - name: Display generated files
         shell: bash
diff --git a/CMakeLists.txt b/CMakeLists.txt
index 214d369..d1e0789 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -7,7 +7,7 @@ project(kaldifeat)
 # remember to change the version in
 # scripts/conda/kaldifeat/meta.yaml
 # scripts/conda-cpu/kaldifeat/meta.yaml
-set(kaldifeat_VERSION "1.25.3")
+set(kaldifeat_VERSION "1.25.4")
 
 set(CMAKE_ARCHIVE_OUTPUT_DIRECTORY "${CMAKE_BINARY_DIR}/lib")
 set(CMAKE_LIBRARY_OUTPUT_DIRECTORY "${CMAKE_BINARY_DIR}/lib")
diff --git a/cmake/cmake_extension.py b/cmake/cmake_extension.py
index 819c0eb..ec82bf6 100644
--- a/cmake/cmake_extension.py
+++ b/cmake/cmake_extension.py
@@ -76,6 +76,7 @@ class BuildExtension(build_ext):
         extra_cmake_args += f" -DCMAKE_INSTALL_PREFIX={Path(self.build_lib).resolve()}/kaldifeat "  # noqa
 
         major, minor = get_pytorch_version().split(".")[:2]
+        print("major, minor", major, minor)
         major = int(major)
         minor = int(minor)
         if major > 2 or (major == 2 and minor >= 1):
diff --git a/scripts/conda-cpu/kaldifeat/meta.yaml b/scripts/conda-cpu/kaldifeat/meta.yaml
index 6ec0877..18167b9 100644
--- a/scripts/conda-cpu/kaldifeat/meta.yaml
+++ b/scripts/conda-cpu/kaldifeat/meta.yaml
@@ -1,6 +1,6 @@
 package:
   name: kaldifeat
-  version: "1.25.3"
+  version: "1.25.4"
 
 source:
   path: "{{ environ.get('KALDIFEAT_ROOT_DIR') }}"
diff --git a/scripts/conda/kaldifeat/meta.yaml b/scripts/conda/kaldifeat/meta.yaml
index 9364472..2bb7afe 100644
--- a/scripts/conda/kaldifeat/meta.yaml
+++ b/scripts/conda/kaldifeat/meta.yaml
@@ -1,6 +1,6 @@
 package:
   name: kaldifeat
-  version: "1.25.3"
+  version: "1.25.4"
 
 source:
   path: "{{ environ.get('KALDIFEAT_ROOT_DIR') }}"