From fd09e5befe81303149354d898062b8deac6bbad0 Mon Sep 17 00:00:00 2001 From: Fangjun Kuang Date: Sat, 23 Dec 2023 00:24:20 +0800 Subject: [PATCH] minor fixes --- .github/workflows/build-cpu-docker.yml | 10 +++++----- .github/workflows/train-librispeech.yml | 7 +++---- 2 files changed, 8 insertions(+), 9 deletions(-) diff --git a/.github/workflows/build-cpu-docker.yml b/.github/workflows/build-cpu-docker.yml index bf1125779..f931f7d09 100644 --- a/.github/workflows/build-cpu-docker.yml +++ b/.github/workflows/build-cpu-docker.yml @@ -1,8 +1,5 @@ name: build-cpu-docker on: - push: - branches: - - ci-train-3 workflow_dispatch: concurrency: @@ -11,7 +8,7 @@ concurrency: jobs: build-cpu-docker: - name: py${{ matrix.python-version }} torch${{ matrix.torch-version }} + name: py${{ matrix.python-version }} torch${{ matrix.torch-version }} v${{ matrix.version }} runs-on: ${{ matrix.os }} strategy: fail-fast: false @@ -21,6 +18,7 @@ jobs: torch-version: ["1.13.0", "2.0.0", "2.0.1", "2.1.0", "2.1.1", "2.1.2"] k2-version: ["1.24.4.dev20231220"] kaldifeat-version: ["1.25.3.dev20231221"] + version: ["1.0"] steps: # refer to https://github.com/actions/checkout @@ -59,7 +57,9 @@ jobs: echo "torch_version: $torch_version" echo "torchaudio_version: $torchaudio_version" - tag=ghcr.io/csukuangfj/icefall:cpu-py${{ matrix.python-version }}-torch${{ matrix.torch-version }} + version=${{ matrix.version }} + + tag=ghcr.io/k2-fsa/icefall:cpu-py${{ matrix.python-version }}-torch${{ matrix.torch-version }}-v$version echo "tag: $tag" docker build \ diff --git a/.github/workflows/train-librispeech.yml b/.github/workflows/train-librispeech.yml index 0a76e0cd7..7c9a28f03 100644 --- a/.github/workflows/train-librispeech.yml +++ b/.github/workflows/train-librispeech.yml @@ -3,7 +3,6 @@ on: push: branches: - master - - ci-train-2 pull_request: branches: @@ -17,7 +16,7 @@ concurrency: jobs: train-librispeech: - name: py${{ matrix.python-version }} torch${{ matrix.torch-version }} + name: py${{ matrix.python-version }} torch${{ matrix.torch-version }} v${{ matrix.version }} runs-on: ${{ matrix.os }} strategy: fail-fast: false @@ -27,6 +26,7 @@ jobs: torch-version: ["1.13.0", "2.0.0", "2.0.1", "2.1.0", "2.1.1", "2.1.2"] k2-version: ["1.24.4.dev20231220"] kaldifeat-version: ["1.25.3.dev20231221"] + version: ["1.0"] steps: # refer to https://github.com/actions/checkout @@ -46,8 +46,7 @@ jobs: - name: Run the build process with Docker uses: addnab/docker-run-action@v3 with: - # image: ghcr.io/k2-fsa/icefall:cpu-py${{ matrix.python-version }} - image: ghcr.io/csukuangfj/icefall:cpu-py${{ matrix.python-version }}-torch${{ matrix.torch-version }} + image: ghcr.io/k2-fsa/icefall:cpu-py${{ matrix.python-version }}-torch${{ matrix.torch-version }}-v${{ matrix.version }} options: | --volume ${{ github.workspace }}/:/icefall shell: bash