From e5fdbcd480272f6c01fcd6e97c135c1b59d871d5 Mon Sep 17 00:00:00 2001 From: Fangjun Kuang Date: Fri, 8 Jul 2022 09:15:37 +0800 Subject: [PATCH] Revert changes to setup_logger. (#468) --- icefall/utils.py | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/icefall/utils.py b/icefall/utils.py index 360f29588..3bfd5e5b1 100644 --- a/icefall/utils.py +++ b/icefall/utils.py @@ -96,8 +96,6 @@ def str2bool(v): def setup_logger( log_filename: Pathlike, log_level: str = "info", - rank: int = 0, - world_size: int = 1, use_console: bool = True, ) -> None: """Setup log level. @@ -108,16 +106,14 @@ def setup_logger( log_level: The log level to use, e.g., "debug", "info", "warning", "error", "critical" - rank: - Rank of this node in DDP training. - world_size: - Number of nodes in DDP training. use_console: True to also print logs to console. """ now = datetime.now() date_time = now.strftime("%Y-%m-%d-%H-%M-%S") - if world_size > 1: + if dist.is_available() and dist.is_initialized(): + world_size = dist.get_world_size() + rank = dist.get_rank() formatter = f"%(asctime)s %(levelname)s [%(filename)s:%(lineno)d] ({rank}/{world_size}) %(message)s" # noqa log_filename = f"{log_filename}-{date_time}-{rank}" else: