From c526e958e5b2a4b31682442107ca28b83adcef50 Mon Sep 17 00:00:00 2001
From: Yifan Yang <yifanyeung@qq.com>
Date: Fri, 2 Jun 2023 23:42:57 +0800
Subject: [PATCH] Fix bug for NewBobScheduler

---
 icefall/rnn_lm/optim.py | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/icefall/rnn_lm/optim.py b/icefall/rnn_lm/optim.py
index d26e1e1cc..21328c7bb 100644
--- a/icefall/rnn_lm/optim.py
+++ b/icefall/rnn_lm/optim.py
@@ -156,7 +156,6 @@ class NewBobScheduler(LRScheduler):
         Args:
           metric: A number for determining whether to change the lr value.
         """
-        factor = 1
         if self.prev_metric is not None:
             if self.prev_metric == 0:
                 improvement = 0
@@ -166,14 +165,14 @@ class NewBobScheduler(LRScheduler):
                 ) / self.prev_metric
             if improvement < self.threshold:
                 if self.current_patient == 0:
-                    factor = self.annealing_factor
+                    self.base_lrs *= self.annealing_factor
                     self.current_patient = self.patient
                 else:
                     self.current_patient -= 1
 
         self.prev_metric = self.current_metric
 
-        return [x * factor for x in self.base_lrs]
+        return self.base_lrs
 
     def state_dict(self):
         return {