From 46eb129b5e1d5c4088d9820d8a5a831dda664957 Mon Sep 17 00:00:00 2001 From: Amir Hussein <36240131+AmirHussein96@users.noreply.github.com> Date: Sat, 13 Sep 2025 11:27:53 -0400 Subject: [PATCH] Apply suggestions from code review Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> --- egs/iwslt22_ta/ASR/RESULTS.md | 4 +--- egs/iwslt22_ta/ASR/local/compute_fbank_gpu.py | 7 ++----- 2 files changed, 3 insertions(+), 8 deletions(-) diff --git a/egs/iwslt22_ta/ASR/RESULTS.md b/egs/iwslt22_ta/ASR/RESULTS.md index c9d8b973f..6b335f676 100644 --- a/egs/iwslt22_ta/ASR/RESULTS.md +++ b/egs/iwslt22_ta/ASR/RESULTS.md @@ -61,9 +61,7 @@ https://tensorboard.dev/experiment/yLE399ZPTzePG8B39jRyOw/ | Decoding method | dev WER | test WER | comment | |------------------------------------|------------|------------|------------------------------------------| -| modified beam search | 47.6 | 51.2 | --epoch 20, --avg 10 | - - +| modified beam search | 40.8 | 44.4 | --epoch 20, --avg 10 | To reproduce the above result, use the following commands for training: diff --git a/egs/iwslt22_ta/ASR/local/compute_fbank_gpu.py b/egs/iwslt22_ta/ASR/local/compute_fbank_gpu.py index 05ed0a74a..e96576bac 100755 --- a/egs/iwslt22_ta/ASR/local/compute_fbank_gpu.py +++ b/egs/iwslt22_ta/ASR/local/compute_fbank_gpu.py @@ -78,16 +78,13 @@ def get_args(): def compute_fbank_gpu(args): src_dir = Path("data/manifests") output_dir = Path("data/fbank") + output_dir.mkdir(parents=True, exist_ok=True) num_jobs = os.cpu_count() num_mel_bins = 80 sampling_rate = 16000 sr = 16000 - dataset_parts = ( - "train", - "test1", - "dev", - ) + dataset_parts = ("dev", "test1") if args.test else ("train", "test1", "dev") manifests = read_manifests_if_cached( prefix="iwslt-ta", dataset_parts=dataset_parts, output_dir=src_dir )