From 4e97b19b6355a4c3afb50f9270f74d96b7988f42 Mon Sep 17 00:00:00 2001
From: Yifan Yang <64255737+yfyeung@users.noreply.github.com>
Date: Mon, 6 May 2024 13:00:27 +0800
Subject: [PATCH 1/2] Remove duplicate logging initialization logic in utils.py
 (#1617)

---
 icefall/utils.py | 9 ---------
 1 file changed, 9 deletions(-)

diff --git a/icefall/utils.py b/icefall/utils.py
index 57467cb56..0c509fc17 100644
--- a/icefall/utils.py
+++ b/icefall/utils.py
@@ -110,13 +110,6 @@ def str2bool(v):
         raise argparse.ArgumentTypeError("Boolean value expected.")
 
 
-def clear_log_handlers():
-    logger = logging.getLogger()
-    handlers = logger.handlers[:]
-    for handler in handlers:
-        logger.removeHandler(handler)
-
-
 def setup_logger(
     log_filename: Pathlike,
     log_level: str = "info",
@@ -133,8 +126,6 @@ def setup_logger(
       use_console:
         True to also print logs to console.
     """
-    clear_log_handlers()
-
     now = datetime.now()
     date_time = now.strftime("%Y-%m-%d-%H-%M-%S")
     if dist.is_available() and dist.is_initialized():

From 9d570870cff167b8b963ed1f73dae0d685ec53cf Mon Sep 17 00:00:00 2001
From: zr_jin <peter.jin.cn@gmail.com>
Date: Tue, 7 May 2024 21:37:55 +0800
Subject: [PATCH 2/2] Update asr_datamodule.py (#1619)

---
 egs/yesno/ASR/tdnn/asr_datamodule.py | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/egs/yesno/ASR/tdnn/asr_datamodule.py b/egs/yesno/ASR/tdnn/asr_datamodule.py
index b9ce8fb4e..99f2a6d08 100644
--- a/egs/yesno/ASR/tdnn/asr_datamodule.py
+++ b/egs/yesno/ASR/tdnn/asr_datamodule.py
@@ -181,7 +181,7 @@ class YesNoAsrDataModule(DataModule):
             train = K2SpeechRecognitionDataset(
                 cut_transforms=transforms,
                 input_strategy=OnTheFlyFeatures(
-                    FbankConfig(sampling_rate=8000, num_mel_bins=23)
+                    Fbank(FbankConfig(sampling_rate=8000, num_mel_bins=23))
                 ),
                 return_cuts=self.args.return_cuts,
             )
@@ -222,9 +222,11 @@ class YesNoAsrDataModule(DataModule):
 
         logging.debug("About to create test dataset")
         test = K2SpeechRecognitionDataset(
-            input_strategy=OnTheFlyFeatures(Fbank(FbankConfig(num_mel_bins=23)))
-            if self.args.on_the_fly_feats
-            else PrecomputedFeatures(),
+            input_strategy=(
+                OnTheFlyFeatures(Fbank(FbankConfig(num_mel_bins=23)))
+                if self.args.on_the_fly_feats
+                else PrecomputedFeatures()
+            ),
             return_cuts=self.args.return_cuts,
         )
         sampler = DynamicBucketingSampler(