From f293264524db7cf067d6ce618382fd056356c8e0 Mon Sep 17 00:00:00 2001 From: Bo-Yi Wu Date: Sat, 15 Aug 2026 11:24:11 +0800 Subject: [PATCH] fix: append .exe suffix to Windows binary download filename The drone-ssh release publishes Windows assets with an .exe suffix (e.g. drone-ssh-1.8.2-windows-amd64.exe), but entrypoint.sh built the download filename without it, so every Windows runner failed with a 404 at the download step (ERR_DOWNLOAD_FAILED). Append .exe when the detected platform is windows. This also keeps the checksums.txt lookup working on Windows since entries match the exact asset name. Add a windows-latest CI job that exercises the download, checksum verification, and binary execution path. Fixes #417 Co-Authored-By: Claude Fable 5 --- .github/workflows/main.yml | 14 ++++++++++++++ entrypoint.sh | 4 ++++ 2 files changed, 18 insertions(+) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 4d5b546..9338189 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -793,6 +793,20 @@ jobs: echo "Output contains 'True'" fi + windows-binary-download: + runs-on: windows-latest + steps: + - name: Checkout code + uses: actions/checkout@v7 + + - name: test binary download and checksum verification + shell: bash + run: | + export GITHUB_ACTION_PATH="$PWD" + export INPUT_CURL_INSECURE=false + export INPUT_CAPTURE_STDOUT=false + ./entrypoint.sh --help + testing-script-error: runs-on: ubuntu-latest steps: diff --git a/entrypoint.sh b/entrypoint.sh index 6658fac..3338f6c 100755 --- a/entrypoint.sh +++ b/entrypoint.sh @@ -39,6 +39,10 @@ function detect_client_info() { detect_client_info DOWNLOAD_URL_PREFIX="${DRONE_SSH_RELEASE_URL}/v${DRONE_SSH_VERSION}" CLIENT_BINARY="drone-ssh-${DRONE_SSH_VERSION}-${CLIENT_PLATFORM}-${CLIENT_ARCH}" +# Windows release assets are published with an .exe suffix +if [[ "${CLIENT_PLATFORM}" == "windows" ]]; then + CLIENT_BINARY="${CLIENT_BINARY}.exe" +fi TARGET="${GITHUB_ACTION_PATH}/${CLIENT_BINARY}" # Check if binary already exists and is executable (caching)